Skip to content

fix: Revert bad string replacements - #2513

Closed
rhcarvalho wants to merge 2 commits into
getsentry:masterfrom
rhcarvalho:private-underscore
Closed

fix: Revert bad string replacements#2513
rhcarvalho wants to merge 2 commits into
getsentry:masterfrom
rhcarvalho:private-underscore

Conversation

@rhcarvalho

@rhcarvalho rhcarvalho commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Fixes changes introduced in 8c60b1e.

Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in packages/typescript/package.json.

@rhcarvalho
fix: Revert bad string replacements
d318a6e 
Fixes changes introduced in 8c60b1e.
Global string replacement was too eager and broke things in raven-node
(although development head is actually in the 4.x branch). Other than
that, this commit fixes doc comments and an entry in
packages/typescript/package.json.
@rhcarvalho
rhcarvalho requested a review from HazAT March 25, 2020 10:05
@rhcarvalho
rhcarvalho requested a review from kamilogorek as a code owner March 25, 2020 10:05
rhcarvalho
rhcarvalho commented Mar 25, 2020
View reviewed changes
Comment thread packages/typescript/package.json
"author": "Sentry",
"license": "BSD-3-Clause",
"private _": false,
"private": false,

@rhcarvalho rhcarvalho Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was broken for quite some time, is this key actually relevant? Isn't "private": false the default?

@kamilogorek kamilogorek Mar 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

rhcarvalho
rhcarvalho commented Mar 25, 2020
View reviewed changes
Comment thread packages/utils/src/misc.ts

/**
* Requires a module which is protected _against bundler minification.
* Requires a module which is protected against bundler minification.

@rhcarvalho rhcarvalho Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what got me started... I thought "why _against?!". The rest is Git history.

@rhcarvalho

rhcarvalho commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

Lint failure was introduced in #2510, broken in master it seems.

https://travis-ci.com/github/getsentry/sentry-javascript/jobs/302473023

@rhcarvalho

rhcarvalho commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

This is the failed build from #2510: https://travis-ci.com/github/getsentry/sentry-javascript/jobs/301043705

@kamilogorek what would you suggest here, a // tslint: comment or is there something better to take out of the linter output?

@sentry/utils: /home/travis/build/getsentry/sentry-javascript/packages/utils/src/supports.ts:109:14
355@sentry/utils: ERROR: 109:14  strict-type-predicates  Expression is always true.
356@sentry/utils: ERROR: 109:21  no-unbound-method       Avoid referencing unbound methods which may cause unintentional scoping of 'this'.
357@sentry/utils: ERROR: 109:25  deprecation             createElement is deprecated.

@rhcarvalho

rhcarvalho commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

Merged with master to pick up changes that should fix the lint error.

@rhcarvalho

rhcarvalho commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

All the new failures (all builds in the job):

@sentry/types: src/index.ts:16:25 - error TS2307: Cannot find module './runtime'.
@sentry/types: 16 export { Runtime } from './runtime';
@sentry/types:                            ~~~~~~~~~~~

@rhcarvalho rhcarvalho mentioned this pull request Mar 25, 2020
Merged
@kamilogorek

kamilogorek commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Fixed and merged manually

@rhcarvalho
rhcarvalho deleted the private-underscore branch March 25, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT Awaiting requested review from HazAT
@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhcarvalho @kamilogorek